Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate otelmemcache, otelgocql #4164

Merged
merged 13 commits into from Sep 6, 2023
Merged

Deprecate otelmemcache, otelgocql #4164

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7b43936
Update CODEOWNERS
pellared Aug 9, 2023
e6f1c6b
Deprecate packages and modules
pellared Aug 9, 2023
a94276f
Update docs
pellared Aug 9, 2023
dc878a8
Update changelog
pellared Aug 9, 2023
39485e7
Update CODEOWNERS
pellared Aug 10, 2023
309c7e1
Update CODEOWNERS
pellared Aug 10, 2023
fb31b41
Merge branch 'main' into deprecate-modules-without-codeowners
pellared Aug 11, 2023
0310edd
Do NOT deprecated zpages
pellared Aug 11, 2023
5c1fa4b
Revert CODEOWNERS changes
pellared Sep 5, 2023
ea2f97b
Merge branch 'main' into deprecate-modules-without-codeowners
pellared Sep 5, 2023
41e3715
Merge branch 'main' into deprecate-modules-without-codeowners
pellared Sep 5, 2023
3dee7b5
Update CHANGELOG.md
pellared Sep 6, 2023
2b0c613
Merge branch 'main' into deprecate-modules-without-codeowners
pellared Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions CODEOWNERS
View file
Open in desktop
pellared marked this conversation as resolved.
Show resolved Hide resolved
Validating CODEOWNERS rules …
Expand Up @@ -25,23 +25,17 @@ CODEOWNERS @MrAlias @MadVikingGod @pellared
detectors/aws/ @open-telemetry/go-approvers @Aneurysm9
detectors/gcp/ @open-telemetry/go-approvers @dashpole

exporters/autoexport @open-telemetry/go-approvers @MikeGoldsmith
exporters/autoexport @open-telemetry/go-approvers @pellared

instrumentation/github.com/astaxie/beego/otelbeego/ @open-telemetry/go-approvers
pellared marked this conversation as resolved.
Show resolved Hide resolved
instrumentation/github.com/aws/aws-lambda-go/otellambda/ @open-telemetry/go-approvers @Aneurysm9
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/ @open-telemetry/go-approvers @Aneurysm9
instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/ @open-telemetry/go-approvers
instrumentation/github.com/emicklei/go-restful/otelrestful/ @open-telemetry/go-approvers
instrumentation/github.com/gin-gonic/gin/otelgin/ @open-telemetry/go-approvers @hanyuancheung
instrumentation/github.com/go-kit/kit/otelkit/ @open-telemetry/go-approvers
pellared marked this conversation as resolved.
Show resolved Hide resolved
instrumentation/github.com/gocql/gocql/otelgocql/ @open-telemetry/go-approvers
instrumentation/github.com/gorilla/mux/otelmux/ @open-telemetry/go-approvers
instrumentation/github.com/labstack/echo/otelecho/ @open-telemetry/go-approvers
instrumentation/github.com/Shopify/sarama/otelsarama/ @open-telemetry/go-approvers @pellared @hanyuancheung
pellared marked this conversation as resolved.
Show resolved Hide resolved
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/ @open-telemetry/go-approvers
instrumentation/google.golang.org/grpc/otelgrpc/ @open-telemetry/go-approvers @dashpole @hanyuancheung
instrumentation/gopkg.in/macaron.v1/otelmacaron/ @open-telemetry/go-approvers

instrumentation/host/ @open-telemetry/go-approvers @MadVikingGod
instrumentation/net/http/httptrace/otelhttptrace/ @open-telemetry/go-approvers @Aneurysm9 @dmathieu
instrumentation/net/http/otelhttp/ @open-telemetry/go-approvers @Aneurysm9 @dmathieu
Expand All @@ -58,5 +52,4 @@ samplers/aws/xray/ @open-te
samplers/jaegerremote/ @open-telemetry/go-approvers
samplers/probability/consistent/ @open-telemetry/go-approvers @MadVikingGod

zpages/ @open-telemetry/go-approvers
instrgen/ @open-telemetry/go-approvers @open-telemetry/go-instrumentation-approvers @MrAlias @pdelewski
2 changes: 2 additions & 0 deletions instrumentation/github.com/Shopify/sarama/otelsarama/example/go.mod
View file
Open in desktop
@@ -1,3 +1,5 @@
// Deprecated: This module is no longer supported.
// github.com/Shopify/sarama moved to github.com/IBM/sarama.
module go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama/example

go 1.18
Expand Down
1 change: 1 addition & 0 deletions instrumentation/github.com/astaxie/beego/otelbeego/example/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego/example

go 1.18
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/doc.go
View file
Open in desktop
Expand Up @@ -19,4 +19,6 @@
//
// The instrumentation works by wrapping the memcached client by calling
// `NewClientWithTracing` and tracing it's every operation.
//
// Deprecated: This module is no longer supported.
package otelmemcache // import "go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache"
2 changes: 1 addition & 1 deletion instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/example/client.go
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ import (

"github.com/bradfitz/gomemcache/memcache"

"go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache"
"go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache" //nolint:staticcheck // This is deprecated and will be removed in the next release.

oteltracestdout "go.opentelemetry.io/otel/exporters/stdout/stdouttrace"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
Expand Down
1 change: 1 addition & 0 deletions instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache

go 1.19
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/test/gomemcache_test.go
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache"
"go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache/internal"
"go.opentelemetry.io/contrib/internal/util"
"go.opentelemetry.io/otel/codes"
Expand Down
1 change: 1 addition & 0 deletions instrumentation/github.com/go-kit/kit/otelkit/example/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit/example

go 1.18
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/github.com/gocql/gocql/otelgocql/doc.go
View file
Open in desktop
Expand Up @@ -13,4 +13,6 @@
// limitations under the License.

// Package otelgocql instruments the github.com/gocql/gocql package.
//
// Deprecated: This module is no longer supported.
package otelgocql // import "go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql"
2 changes: 1 addition & 1 deletion instrumentation/github.com/gocql/gocql/otelgocql/example/client.go
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ import (
"go.opentelemetry.io/otel/sdk/metric/aggregation"
"go.opentelemetry.io/otel/sdk/trace"

"go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql"
"go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql" //nolint:staticcheck // This is deprecated and will be removed in the next release.
)

const keyspace = "gocql_integration_example"
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/github.com/gocql/gocql/otelgocql/example/doc.go
View file
Open in desktop
Expand Up @@ -13,4 +13,6 @@
// limitations under the License.

// Package main provides an example use of the otelgocql instrumentation.
//
// Deprecated: This module is no longer supported.
package main
1 change: 1 addition & 0 deletions instrumentation/github.com/gocql/gocql/otelgocql/example/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql/example

go 1.18
Expand Down
1 change: 1 addition & 0 deletions instrumentation/github.com/gocql/gocql/otelgocql/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql

go 1.19
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gocql/gocql/otelgocql/test/gocql_test.go
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql"
"go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql/otelgocql/internal"
"go.opentelemetry.io/contrib/internal/util"
"go.opentelemetry.io/otel/attribute"
Expand Down
19 changes: 19 additions & 0 deletions zpages/doc.go
View file
Open in desktop
@@ -0,0 +1,19 @@
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// Package zpages implements a collection of HTML pages that display
// telemetry stats.
pellared marked this conversation as resolved.
Show resolved Hide resolved
//
// Deprecated: This module is no longer supported.
package zpages // import "go.opentelemetry.io/contrib/zpages"
1 change: 1 addition & 0 deletions zpages/go.mod
View file
Open in desktop
@@ -1,3 +1,4 @@
// Deprecated: This module is no longer supported.
module go.opentelemetry.io/contrib/zpages

go 1.19
Expand Down