Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate otelkit #4093

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Deprecate otelkit #4093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc51dd9
Deprecate otelkit
pellared Jul 21, 2023
e443731
Merge branch 'main' into deprecate-otelkit
pellared Jul 23, 2023
22da99e
Update README.md
pellared Jul 24, 2023
1837301
Merge branch 'main' into deprecate-otelkit
pellared Jul 27, 2023
3b053c6
Merge branch 'main' into deprecate-otelkit
pellared Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Deprecated

- The `go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego` module is deprecated. (#4092)
- The `go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit` module is deprecated. (#4093)

### Removed

Expand Down
1 change: 0 additions & 1 deletion instrumentation/README.md
View file
Open in desktop
Expand Up @@ -46,7 +46,6 @@ The following instrumentation packages are provided for popular Go packages and
| [github.com/bradfitz/gomemcache](./github.com/bradfitz/gomemcache/memcache/otelmemcache) | | ✓ |
| [github.com/emicklei/go-restful](./github.com/emicklei/go-restful/otelrestful) | | ✓ |
| [github.com/gin-gonic/gin](./github.com/gin-gonic/gin/otelgin) | | ✓ |
| [github.com/go-kit/kit](./github.com/go-kit/kit/otelkit) | | ✓ |
| [github.com/gocql/gocql](./github.com/gocql/gocql/otelgocql) | ✓ | ✓ |
| [github.com/gorilla/mux](./github.com/gorilla/mux/otelmux) | | ✓ |
| [github.com/labstack/echo](./github.com/labstack/echo/otelecho) | | ✓ |
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/github.com/go-kit/kit/otelkit/doc.go
View file
Open in desktop
Expand Up @@ -19,4 +19,6 @@
// For instrumenting the transport layer,
// look at the instrumentation libraries provided by go.opentelemetry.io/contrib.
// Learn more about go-kit's layers at https://gokit.io/faq/#architecture-and-design.
//
// Deprecated: This module is no longer supported.
package otelkit // import "go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit"
2 changes: 1 addition & 1 deletion instrumentation/github.com/go-kit/kit/otelkit/example/server.go
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ import (
sdktrace "go.opentelemetry.io/otel/sdk/trace"
oteltrace "go.opentelemetry.io/otel/trace"

"go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit"
"go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit" //nolint:staticcheck // This is deprecated and will be removed in the next release.
)

var tracer = otel.Tracer("kit-server")
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/go-kit/kit/otelkit/test/endpoint_test.go
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit"
"go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/codes"
Expand Down