Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaegerremote: Add WithSamplingStrategyFetcher option #4045

Merged
merged 16 commits into from
Sep 29, 2023

Merge branch 'main' into public-fetcher-interface

51c2c31
Select commit
Failed to load commit list.
Merged

jaegerremote: Add WithSamplingStrategyFetcher option #4045

Merge branch 'main' into public-fetcher-interface
51c2c31
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Sep 29, 2023 in 0s

82.2% (+0.0%) compared to 9d4eb7e

View this Pull Request on Codecov

82.2% (+0.0%) compared to 9d4eb7e

Details

Codecov Report

Merging #4045 (51c2c31) into main (9d4eb7e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4045   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files        144     144           
  Lines      10005   10002    -3     
=====================================
  Hits        8226    8226           
+ Misses      1638    1636    -2     
+ Partials     141     140    -1     
Files Coverage Δ
samplers/jaegerremote/sampler_remote.go 89.4% <100.0%> (-0.3%) ⬇️
samplers/jaegerremote/sampler_remote_options.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes