otelmux: Treat incoming trace ID as links rather than parents

[elaous]

When a trace is sent with a trace context creates a problem where the traces is trying to making our traces a child of a parent that is not sent to the collectors. The otelmux package that we use doesn't provide a solution to this problem but otelhttp does. Using otelhttp as a guide marking endpoints as public is a good way to avoid orphan spans. This will treat incoming trace ID as links rather than parents.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: elaous / name: Samir El Aouar (bf091d5)

[codecov]

Codecov Report

Merging #3661 (fc0ea15) into main (c347e83) will increase coverage by 0.0%.
The diff coverage is 55.3%.

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #3661    +/-   ##
======================================
  Coverage   70.3%   70.4%            
======================================
  Files        147     149     +2     
  Lines       6959    7123   +164     
======================================
+ Hits        4899    5017   +118     
- Misses      1939    1974    +35     
- Partials     121     132    +11     

Impacted Files	Coverage Δ
detectors/aws/ec2/version.go	0.0% <0.0%> (ø)
detectors/aws/ecs/version.go	0.0% <0.0%> (ø)
detectors/aws/eks/version.go	0.0% <0.0%> (ø)
detectors/gcp/version.go	0.0% <0.0%> (ø)
...thub.com/Shopify/sarama/otelsarama/test/version.go	0.0% <0.0%> (ø)
...github.com/astaxie/beego/otelbeego/test/version.go	0.0% <0.0%> (ø)
...tion/github.com/astaxie/beego/otelbeego/version.go	0.0% <0.0%> (ø)
...thub.com/aws/aws-sdk-go-v2/otelaws/test/version.go	0.0% <0.0%> (ø)
...om/emicklei/go-restful/otelrestful/test/version.go	0.0% <0.0%> (ø)
...n/github.com/gin-gonic/gin/otelgin/test/version.go	0.0% <0.0%> (ø)
... and 34 more

... and 3 files with indirect coverage changes

[elaous]

Hi, just wondering, what are the next steps. There is anything on my side that needs to be done?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: elaous / name: Samir El Aouar (bf091d5, a4bb769, f42102e, 1374ae1, 7316b3f, 28dd0fd, 9ce7235, 61812f1, 5a83709, 30c6217, 5fdeebf, c362cfb)

[dmathieu]

First, it looks like one of your commits is having CLA issues. Can you fix that?

[elaous]

First, it looks like one of your commits is having CLA issues. Can you fix that?
I updated with changes from master and it fixed the issue.

[pellared]

@open-telemetry/go-maintainers This PR has already 3 approvals so it is probably good to merge.

[MrAlias]

@open-telemetry/go-maintainers This PR has already 3 approvals so it is probably good to merge.

Reviews were re-requested for @Aneurysm9 and @dmathieu and they have not provided them.

[elaous]

@open-telemetry/go-maintainers This PR has already 3 approvals so it is probably good to merge.

Reviews were re-requested for @Aneurysm9 and @dmathieu and they have not provided them.

Sorry for the clueless question: How I dismissing a pull request review? Has been some time since I used Github.

[MrAlias]

@open-telemetry/go-maintainers This PR has already 3 approvals so it is probably good to merge.

Reviews were re-requested for @Aneurysm9 and @dmathieu and they have not provided them.

Sorry for the clueless question: How I dismissing a pull request review? Has been some time since I used Github.

NP, I don't know if you can based on the project settings and the default permissions.

I can dismiss them if you like?

[elaous]

@open-telemetry/go-maintainers This PR has already 3 approvals so it is probably good to merge.

Reviews were re-requested for @Aneurysm9 and @dmathieu and they have not provided them.

Sorry for the clueless question: How I dismissing a pull request review? Has been some time since I used Github.

NP, I don't know if you can based on the project settings and the default permissions.

I can dismiss them if you like?

Yes please.

stale

[elaous]

There is anything I can do about codeconv/patch?

[MrAlias]

There is anything I can do about codeconv/patch?

If you would like to submit a follow up PR to help improve the projects overall coverage we would be happy to have it. But, for this PR, the coverage is good enough.

[ash2k]

Would be great to have this for the gRPC instrumentation too.