Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump detector semconv to v1.24.0 #4803

Merged
merged 6 commits into from Jan 16, 2024
Merged

Bump detector semconv to v1.24.0 #4803

merged 6 commits into from Jan 16, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 11, 2024 •
edited

Fix #4698

  • The semantic conventions used by go.opentelemetry.io/contrib/detectors/aws/ecs are upgraded to v1.24.0.
  • The semantic conventions used by go.opentelemetry.io/contrib/detectors/aws/lambda are upgraded to v1.24.0.
  • The semantic conventions used by go.opentelemetry.io/contrib/detectors/aws/ec2 are upgraded to v1.24.0.
  • The semantic conventions used by go.opentelemetry.io/contrib/detectors/aws/eks are upgraded to v1.24.0.
  • The semantic conventions used by go.opentelemetry.io/contrib/detectors/gcp are upgraded to v1.24.0.
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/test are upgraded to v1.24.0.

@MrAlias MrAlias added the area: detector Related to a detector package label Jan 11, 2024
@MrAlias MrAlias requested review from Aneurysm9, a team and dashpole as code owners January 11, 2024 20:44
@MrAlias MrAlias added this to the v0.47.0 milestone Jan 11, 2024
carrbs
carrbs reviewed Jan 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
carrbs
carrbs suggested changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@carrbs carrbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update semconv here too?

opentelemetry-go-contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/lambda.go

Line 27 in 3cecdcf

semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

pellared
pellared reviewed Jan 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias force-pushed the bump-semconv-v1.24.0-resources branch from 35be77a to 051cedd Compare January 16, 2024 15:35
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 16, 2024

Do we need to update semconv here too?

opentelemetry-go-contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/lambda.go

Line 27 in 3cecdcf

semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

Eventually yes, but it is not scoped within this PR.

@MrAlias MrAlias merged commit ffc47ec into open-telemetry:main Jan 16, 2024
22 checks passed
@MrAlias MrAlias deleted the bump-semconv-v1.24.0-resources branch January 16, 2024 18:16
@MadVikingGod MadVikingGod mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrbs carrbs carrbs requested changes

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
area: detector Related to a detector package
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging this pull request may close these issues.

Upgrade all resource detectors to use go.opentelemetry.io/otel/semconv/v1.24.0
5 participants
@MrAlias @dmathieu @carrbs @dashpole @pellared