Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add SDK.Shutdown method #4583

Merged
merged 8 commits into from Nov 24, 2023

Conversation

codeboten
Copy link
Contributor

This allows users to call Shutdown on the tracer/meter providers configured in the SDK.

This allows users to call Shutdown on the tracer/meter providers configured in the SDK.

Signed-off-by: Alex Boten <aboten@lightstep.com>
config/config.go Outdated Show resolved Hide resolved
Alex Boten added 2 commits November 16, 2023 13:41
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #4583 (29b0bc9) into main (9f26914) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4583   +/-   ##
=====================================
  Coverage   80.9%   80.9%           
=====================================
  Files        150     150           
  Lines      10349   10361   +12     
=====================================
+ Hits        8376    8388   +12     
  Misses      1831    1831           
  Partials     142     142           
Files Coverage Δ
config/config.go 100.0% <100.0%> (ø)
config/metric.go 100.0% <100.0%> (ø)
config/trace.go 100.0% <100.0%> (ø)

Alex Boten added 2 commits November 16, 2023 13:46
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add a changelog entry.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten
Copy link
Contributor Author

Thanks for the review @pellared, changelog added

@pellared pellared merged commit ab49dc8 into open-telemetry:main Nov 24, 2023
22 checks passed
@pellared pellared changed the title config: add Shutdown method config: add SDK.Shutdown method Nov 24, 2023
@codeboten codeboten deleted the codeboten/add-shutdown branch November 24, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants