otelgrpc: Add peer attributes to spans generated by stats handlers #4531
Labels
area: instrumentation
Related to an instrumentation package
enhancement
New feature or request
instrumentation: otelgrpc
Milestone
The trace instrumentation implemented in #3002 misses peer attributes.
opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go
Lines 78 to 84 in 23181f7
The
span
returned inTagConn
is alwaysnoop
asTagConn
is invoked beforeTagRPC
, therefore the peer attributes are never added to the spans.Currently seems to be blocked by grpc/grpc-go#6897.
The text was updated successfully, but these errors were encountered: