Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Stats handlers do not honor WithMessageEvents option #4533

Closed
pellared opened this issue Nov 7, 2023 · 3 comments · Fixed by #4536
Closed

otelgrpc: Stats handlers do not honor WithMessageEvents option #4533

pellared opened this issue Nov 7, 2023 · 3 comments · Fixed by #4536
Assignees
@fatsheep9146
Labels
bug Something isn't working instrumentation: otelgrpc
Milestone
v0.47.0

Comments

@pellared
Copy link
Member

pellared commented Nov 7, 2023

Current

For otelgrpc stats handllers the message events are always emitted. They cannot be filtered using otelgrpc.WithMessageEvents

Expected

User can use otelgrpc.WithMessageEvents to specify which events are emitted.
@pellared pellared added bug Something isn't working instrumentation: otelgrpc labels Nov 7, 2023
@pellared pellared added this to the v0.47.0 milestone Nov 7, 2023
@pellared
Copy link
Member Author

pellared commented Nov 7, 2023

@fatsheep9146 Do you want to take this?

@pellared
Copy link
Member Author

pellared commented Nov 7, 2023

This blocks #4534

@pellared pellared mentioned this issue Nov 7, 2023
Merged
@fatsheep9146
Copy link
Contributor

@fatsheep9146 Do you want to take this?

No problem. Since this blocks another pr, I will first resolve this and then resolve #4531
@pellared

@fatsheep9146 fatsheep9146 mentioned this issue Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
bug Something isn't working instrumentation: otelgrpc
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging a pull request may close this issue.

otelgrpc: Fix stats handlers to honor WithMessageEvents option fatsheep9146/opentelemetry-go-contrib
2 participants
@pellared @fatsheep9146