Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttp: maps are used when just normal fields could be #4502

Closed
pellared opened this issue Nov 2, 2023 · 0 comments · Fixed by #4615
Closed

otelhttp: maps are used when just normal fields could be #4502

pellared opened this issue Nov 2, 2023 · 0 comments · Fixed by #4615

Comments

@pellared
Copy link
Member

pellared commented Nov 2, 2023

it's really weird that maps are used when just normal fields could be. What is the reason? Map lookup involves computing the hash of the string key, etc and is definitely more work for the CPU vs just a pointer dereference.

Originally posted by @ash2k in #4500 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

otelhttp: use plain fields ash2k/opentelemetry-go-contrib
1 participant
@pellared