Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce OpenTelemetry events in gRPC interceptor #3964

Merged
merged 13 commits into from Jun 20, 2023

Conversation

Baliedge
Copy link
Contributor

@Baliedge Baliedge commented Jun 5, 2023

  • Change in behavior: Disable logging of RECEIVED/SENT events in gRPC spans from interceptors.
    • Implement WithMessageEvents() option to enable these events.
    • Mirrors convention used in the go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp instrumentation.
    • Disabling Span Events #3679

Disables `SENT`/`RECEIVED` events in the span.
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@Baliedge Baliedge changed the title PIP-2499: Reduce OpenTelemetry events [WIP] PIP-2499: Reduce OpenTelemetry events Jun 5, 2023
@Baliedge Baliedge changed the title [WIP] PIP-2499: Reduce OpenTelemetry events [WIP] Reduce OpenTelemetry events Jun 5, 2023
@Baliedge Baliedge force-pushed the Baliedge/PIP-2499-reduce-events branch from c2d5fb7 to 372930d Compare June 5, 2023 20:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Baliedge Baliedge changed the title [WIP] Reduce OpenTelemetry events [WIP] Reduce OpenTelemetry events in gRPC interceptor Jun 5, 2023
@dmathieu dmathieu added the blocked: CLA Waiting on CLA to be signed before progress can be made label Jun 6, 2023
@Baliedge Baliedge marked this pull request as ready for review June 7, 2023 15:45
@Baliedge Baliedge requested review from a team, dashpole and hanyuancheung as code owners June 7, 2023 15:45
@Baliedge Baliedge changed the title [WIP] Reduce OpenTelemetry events in gRPC interceptor Reduce OpenTelemetry events in gRPC interceptor Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3964 (731ed52) into main (7abf94b) will increase coverage by 0.0%.
The diff coverage is 92.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3964   +/-   ##
=====================================
  Coverage   79.1%   79.2%           
=====================================
  Files        165     165           
  Lines      10293   10318   +25     
=====================================
+ Hits        8151    8173   +22     
- Misses      2006    2008    +2     
- Partials     136     137    +1     
Impacted Files Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 85.0% <91.1%> (-0.2%) ⬇️
...entation/google.golang.org/grpc/otelgrpc/config.go 71.1% <100.0%> (+6.0%) ⬆️

@dmathieu dmathieu removed the blocked: CLA Waiting on CLA to be signed before progress can be made label Jun 8, 2023
@hanyuancheung
Copy link
Member

hanyuancheung commented Jun 8, 2023

❤️ Thanks for ur contribution. @Baliedge

k8s-publishing-bot pushed a commit to kubernetes/api that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/client-go that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/code-generator that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/component-base that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/component-helpers that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kms that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/apiserver that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kube-aggregator that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/sample-apiserver that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/sample-controller that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/apiextensions-apiserver that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/metrics that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/cli-runtime that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/sample-cli-plugin that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kube-proxy that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/cri-api that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kubelet that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kube-scheduler that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/controller-manager that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/cloud-provider that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kube-controller-manager that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/cluster-bootstrap that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/csi-translation-lib that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/mount-utils that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/kubectl that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/pod-security-admission that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/dynamic-resource-allocation that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot pushed a commit to kubernetes/endpointslice that referenced this pull request Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964

Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
jingczhang pushed a commit to nokia/kubernetes that referenced this pull request May 7, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants