Add instrgen implementation #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
5 times, most recently
from
ea147d9
to
2f7f181
Compare
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
14 times, most recently
from
0039758
to
24451d9
Compare
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
from
da9aa79
to
ee021aa
Compare
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
from
5686e6a
to
ad2bef0
Compare
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
from
ad2bef0
to
40b94be
Compare
|
SIG meeting: plan is to add a readme to this. |
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
from
76c9f73
to
4bd3b5d
Compare
MrAlias
reviewed
Mar 21, 2023
MrAlias
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
This looks good enough to start with. I've found a fair amount of issues, but I don't think any of them fundamentally block this from being merged as a starting point.
Thanks for getting this all together @pdelewski! 🎉
pdelewski
force-pushed
the
adding-instrgen-implementation
branch
from
be359f2
to
c40b6de
Compare
dineshg13
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
This is a good start. I was able to instrument a sample HTTP server using this. @pdelewski Thanks for the contribution.
|
@MrAlias Seems that we can merge it. |
|
Merging as this has 2 reviews from the @open-telemetry/go-instrumentation-approvers group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.