Add instrgen directory for source level instrumentation

[pdelewski]

This PR adds new directory for source instrumentation according to discussions

open-telemetry/opentelemetry-go-instrumentation#3
#2834

[MrAlias]

Please update the owners file with the @open-telemetry/go-approvers, you @pdelewski, and me the owners of this directory.

[pdelewski]

@MrAlias Seems that my user does not have write access rights to this repo

[MrAlias]

@MrAlias Seems that my user does not have write access rights to this repo

@Aneurysm9 is this an issue you've seen in the collector contrib?

[MrAlias]

Please add an instrgen/go.mod to identify the new directory as a go module.

[MrAlias]

@MrAlias Seems that my user does not have write access rights to this repo

@Aneurysm9 is this an issue you've seen in the collector contrib?

@pdelewski it sounds like these types of errors are ignored in the collector contrib. It will not be a blocker to merging as it will correctly identify the owner of the new package.

[pdelewski]

@MrAlias I updated Readme.md according to your suggestions. Please check it and approve if everything is ok. I plan to open a PR with instrgen implementation ASAP

[MrAlias]

This is still needed.

Please add an instrgen/go.mod to identify the new directory as a go module.

Be sure to run the dependabot generation script after it is added.

[MrAlias]

Looks good outside of adding a go.mod file.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pdelewski / name: Przemyslaw Delewski (0b2d2c0)

[pdelewski]

Looks good outside of adding a go.mod file.

This now is failing as there are no go files to analyze. Should not go.mod be added together with implementation?

[MrAlias]

Looks good outside of adding a go.mod file.

This now is failing as there are no go files to analyze. Should not go.mod be added together with implementation?

Adding a doc.go file will solve this. E.g.

// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

/*
Package instrgen provides a code generation utility that instruments existing
source code with OpenTelemetry.
*/
package instrgen // import "go.opentelemetry.io/contrib/instrgen"

[pdelewski]

@MrAlias Seems that I cannot merge it

[MrAlias]

@MrAlias Seems that I cannot merge it

Right. That is something maintainers of this project will do.

First, the tests need to succeed and another approver from another company needs to approve this: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#pull-requests

[pdelewski]

@MrAlias Seems that I cannot merge it

Right. That is something maintainers of this project will do.

First, the tests need to succeed and another approver from another company needs to approve this: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#pull-requests

@jmacd @MadVikingGod Could you look at this PR?

[pdelewski]

@MadVikingGod Could you merge it? as I don't have permissions yet

[MadVikingGod]

@pdelewski Even after this is merged you won't have merge permissions. That is only permitted to the maintainers group.

[pdelewski]

@pdelewski Even after this is merged you won't have merge permissions. That is only permitted to the maintainers group.

@MadVikingGod Yes, I know but approver should have them, right?