Fix flaky tests in samplers/jaegerremote (#4402)

open-telemetry · Oct 10, 2023 · eb489c5 · eb489c5
1 parent 074ac11
commit eb489c5
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/samplers/jaegerremote/sampler_remote_test.go b/samplers/jaegerremote/sampler_remote_test.go
@@ -121,6 +121,7 @@ func TestRemoteSamplerOptions(t *testing.T) {
 		withUpdaters(updaters...),
 		WithLogger(logger),
 	)
+	defer sampler.Close()
 	assert.Equal(t, 42, sampler.posParams.MaxOperations)
 	assert.True(t, sampler.posParams.OperationNameLateBinding)
 	assert.Same(t, initSampler, sampler.sampler)
@@ -495,6 +496,7 @@ func TestRemotelyControlledSampler_updateRateLimitingOrProbabilisticSampler(t *t
 					new(rateLimitingSamplerUpdater),
 				),
 			)
+			defer remoteSampler.Close()
 			err := remoteSampler.updateSamplerViaUpdaters(testCase.res)
 			if testCase.shouldErr {
 				require.Error(t, err)