Update OTLP Exporter README #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishweshbankwar
approved these changes
Aug 26, 2023
| @@ -175,8 +175,6 @@ values of the `PeriodicExportingMetricReaderOptions` | |||
| | `OTEL_METRIC_EXPORT_INTERVAL` | `ExportIntervalMilliseconds` | | |||
| | `OTEL_METRIC_EXPORT_TIMEOUT` | `ExportTimeoutMilliseconds` | | |||
|
|
|||
| NOTE: `OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE` is not supported yet [#3756](https://github.com/open-telemetry/opentelemetry-dotnet/issues/3756). | |||
There was a problem hiding this comment.
Just mention with one liner that the environment variable is supported.
There was a problem hiding this comment.
please also call out the values suported. I dont think we support all the values. (like lowmemory)
There was a problem hiding this comment.
@cijothomas is support for LowMemory on the roadmap, or blocked by anything specific we can follow in the meantime?
There was a problem hiding this comment.
@utpilla The above link has the spec for lowmemory.
@austindrenski I don't think there are any blockers implementing lowmemory. Its just that nobody asked for it so far! Could you open an issue for it to better track adding it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCEnot being supported. This was completed in Add support for OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE environment variable #4667