Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional extension method for otlp log exporter to configure processor options #4733

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Aug 2, 2023

Fixes #4388
Design discussion issue #

Changes

An additional extension to configure export processor options for otlp log exporter.

TODO: updated Readme

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review August 2, 2023 15:47
@vishweshbankwar vishweshbankwar requested a review from a team as a code owner August 2, 2023 15:47
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4733 (9030926) into main (a76564e) will increase coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 9030926 differs from pull request most recent head 5926d1f. Consider uploading reports for the commit 5926d1f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4733      +/-   ##
==========================================
+ Coverage   81.94%   82.04%   +0.10%     
==========================================
  Files         313      313              
  Lines       12731    12741      +10     
==========================================
+ Hits        10432    10453      +21     
+ Misses       2299     2288      -11     
Files Changed Coverage Δ
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 96.36% <ø> (ø)
...try/Logs/ILogger/OpenTelemetryLoggingExtensions.cs 100.00% <ø> (ø)
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 96.15% <100.00%> (+8.65%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit a869e61 into open-telemetry:main Aug 4, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchExportProcessorOptions for otlp log exporter
4 participants