Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDITORIAL] fix changelog entry for PR 3185 #3217

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

dbarker
Copy link
Contributor

@dbarker dbarker commented Dec 19, 2024

Fixes the CHANGELOG entry which was made under the earlier release by mistake

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Sorry, something went wrong.

…ous release
@dbarker dbarker requested a review from a team as a code owner December 19, 2024 16:04
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 16a5bf8
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67644b7c08ed590008fa89cf

@dbarker
Copy link
Contributor Author

dbarker commented Dec 19, 2024

@marcalff heads up on this. I just saw I placed the entry incorrectly on my first PR.

@dbarker dbarker changed the title fix to move changelog entry that was incorrectly placed under a previ… fix to move changelog entry that was incorrectly placed Dec 19, 2024
@marcalff marcalff changed the title fix to move changelog entry that was incorrectly placed [EDITORIAL] fix changelog entry for PR 3185 Dec 19, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noticing and fixing.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (807d610) to head (16a5bf8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737           

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@marcalff marcalff merged commit 4998eb1 into open-telemetry:main Dec 19, 2024
57 checks passed
@dbarker dbarker deleted the fix_changelog_entry branch March 31, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants