Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporterhelper] fix missed metric aggregations #9048

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[exporterhelper] fix missed metric aggregations #9048

merged 4 commits into from
Dec 6, 2023

Commits on Dec 5, 2023

  1. [exporterhelper] fix missed metric aggregations 

    This PR ensures that context cancellation in the exporter doesn't interfere with metric aggregation. The OTel SDK currently returns if there's an error in the context used in `Add` (see https://github.com/open-telemetry/opentelemetry-go/blob/6cee2b4a4c76b581115d0d0ca150ad8b2e683db6/sdk/metric/instrument.go#L241-L243). This means that if there's a cancelled context in an export, the metrics are not recorded.

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3643b93 View commit details
    Browse the repository at this point in the history

  2. WithoutCancel is a go 1.21 method. Will add an issue to track changin… 

    …g this when 1.22 is out

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5443f7e View commit details
    Browse the repository at this point in the history

  3. implement temporary withoutCancel 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    323e70d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. use noCancellationContext 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f398d19 View commit details
    Browse the repository at this point in the history