fix incorrect use of fsnotify in configtls #8439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Sep 13, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bogdandrutu
reviewed
Sep 14, 2023
| @@ -112,7 +112,7 @@ func (r *clientCAsFileReloader) handleWatcherEvents() { | |||
| // NOTE: k8s configmaps uses symlinks, we need this workaround. | |||
| // original configmap file is removed. | |||
| // SEE: https://martensson.io/go-fsnotify-and-kubernetes-configmaps/ | |||
| if event.Op == fsnotify.Remove || event.Op == fsnotify.Chmod { | |||
| if event.Has(fsnotify.Remove) || event.Has(fsnotify.Chmod) { | |||
There was a problem hiding this comment.
My confusion here is why we need to monitor for the chmod...
There was a problem hiding this comment.
Possibly because of this fsnotify/fsnotify#421?
There was a problem hiding this comment.
Inotify generates IN_DELETE_SELF for the watched file only when its link count is reduces to 0. Looks like it is used to handle this situation. 🤔
https://github.com/fsnotify/fsnotify/blob/v1.6.0/backend_inotify.go#L26-L33
codeboten
approved these changes
Sep 15, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: fix #8438
Link to tracking Issue: #8438