[chore] [pdata] Add test coverage for slices Sort method #7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.59% // Head: 90.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7115 +/- ##
==========================================
+ Coverage 90.59% 90.82% +0.22%
==========================================
Files 293 293
Lines 14254 14254
==========================================
+ Hits 12914 12946 +32
+ Misses 1072 1040 -32
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
force-pushed
the
pdata-cover-sort
branch
3 times, most recently
from
df9317e
to
a811629
Compare
bogdandrutu
reviewed
Feb 4, 2023
| return uintptr(unsafe.Pointer(a.orig)) < uintptr(unsafe.Pointer(b.orig)) | ||
| }) | ||
| for i := 1; i < es.Len(); i++ { | ||
| assert.True(t, uintptr(unsafe.Pointer(es.At(i-1).orig)) < uintptr(unsafe.Pointer(es.At(i).orig))) |
There was a problem hiding this comment.
Surprisingly assert.Less doesn't support uintptr
There was a problem hiding this comment.
Trying to fix that :) stretchr/testify#1339
There was a problem hiding this comment.
Maybe add a TODO to change this if the PR gets merged.
bogdandrutu
approved these changes
Feb 4, 2023
dmitryax
force-pushed
the
pdata-cover-sort
branch
from
a811629
to
4b7cbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.