[confighttp] Add support for cookies #10176
Open
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10176 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 387 387
Lines 18246 18252 +6
=======================================
+ Hits 16871 16877 +6
Misses 1028 1028
Partials 347 347 ☔ View full report in Codecov by Sentry. |
atoulme
commented
May 19, 2024
| if hcs.CookiesEnabled { | ||
| jar, err = cookiejar.New(nil) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This line cannot be tested, the New method returns nil always for now. I am just checking the error returned in case this changes in the future.
mx-psi
reviewed
May 20, 2024
|
@mx-psi are we good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for cookies in HTTP clients with
cookies::enabled.Link to tracking issue
Fixes #10175
Testing
Unit test
Documentation
Added to README