[confmap] Remove deprecated ResolverSettings fields #10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 17, 2024
…3113) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `Providers` has been deprecated since v0.99.0. Needed for open-telemetry/opentelemetry-collector#10173.
songy23
approved these changes
May 17, 2024
bogdandrutu
approved these changes
May 20, 2024
| } | ||
| converters := make([]Converter, len(set.ConverterFactories)) | ||
| for i, factory := range set.ConverterFactories { | ||
| converters[i] = factory.Create(set.ConverterSettings) |
There was a problem hiding this comment.
Separate PR/issue. It would be great to have all public APIs like Create always accept context.Context as the first argument.
mx-psi
approved these changes
May 20, 2024
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10173 +/- ##
==========================================
- Coverage 91.89% 91.87% -0.02%
==========================================
Files 356 356
Lines 16877 16865 -12
==========================================
- Hits 15509 15495 -14
- Misses 1030 1031 +1
- Partials 338 339 +1 ☔ View full report in Codecov by Sentry. |
evan-bradley
force-pushed
the
remove-confmap-instances
branch
from
952cdb0
to
c991ebf
Compare
codeboten
pushed a commit
that referenced
this pull request
May 21, 2024
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
…0173) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description These fields were deprecated in v0.99.0 and aren't used in any upstream repositories. These appear to still be used in downstream distributions. If we want to lengthen the deprecation period for these fields, I'll open a PR to instead set a timeline for their removal.
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These fields were deprecated in v0.99.0 and aren't used in any upstream repositories.
These appear to still be used in downstream distributions. If we want to lengthen the deprecation period for these fields, I'll open a PR to instead set a timeline for their removal.