Skip to content

Commit

Permalink
comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jmacd committed Feb 2, 2024
1 parent 5219efc commit 14ab778
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions exporter/otlpexporter/otlp.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (e *baseExporter) pushTraces(ctx context.Context, td ptrace.Traces) error {
if !(partialSuccess.ErrorMessage() == "" && partialSuccess.RejectedSpans() == 0) {
// TODO: These should be counted as "rejected", similar to dropped items.
// https://github.com/open-telemetry/opentelemetry-collector/issues/9243
// Note the zap logging key is chosen for consistency with ../exporterhelper.
// Note the logging key is chosen for consistency with ../exporterhelper.
e.settings.Logger.Warn("Partial success response",
zap.String("message", resp.PartialSuccess().ErrorMessage()),
zap.Int64("dropped_spans", resp.PartialSuccess().RejectedSpans()),
Expand All @@ -119,7 +119,7 @@ func (e *baseExporter) pushMetrics(ctx context.Context, md pmetric.Metrics) erro
if !(partialSuccess.ErrorMessage() == "" && partialSuccess.RejectedDataPoints() == 0) {
// TODO: These should be counted as "rejected", similar to dropped items.
// https://github.com/open-telemetry/opentelemetry-collector/issues/9243
// Note the zap logging key is chosen for consistency with ../exporterhelper.
// Note the logging key is chosen for consistency with ../exporterhelper.
e.settings.Logger.Warn("Partial success response",
zap.String("message", resp.PartialSuccess().ErrorMessage()),
zap.Int64("dropped_data_points", resp.PartialSuccess().RejectedDataPoints()),
Expand All @@ -138,7 +138,7 @@ func (e *baseExporter) pushLogs(ctx context.Context, ld plog.Logs) error {
if !(partialSuccess.ErrorMessage() == "" && partialSuccess.RejectedLogRecords() == 0) {
// TODO: These should be counted as "rejected", similar to dropped items.
// https://github.com/open-telemetry/opentelemetry-collector/issues/9243
// Note the zap logging key is chosen for consistency with ../exporterhelper.
// Note the logging key is chosen for consistency with ../exporterhelper.
e.settings.Logger.Warn("Partial success response",
zap.String("message", resp.PartialSuccess().ErrorMessage()),
zap.Int64("dropped_log_records", resp.PartialSuccess().RejectedLogRecords()),
Expand Down

0 comments on commit 14ab778

Please sign in to comment.