[chore][mdatagen] Use MustNewType for metadata.Type #31038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/mdatagen
mx-psi
requested review from
MovieStoreGuy,
andrzej-stencel,
dashpole,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
Aneurysm9,
TylerHelmuth,
yurishkuro,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
songy23
approved these changes
Feb 5, 2024
dmitryax
approved these changes
Feb 5, 2024
andrzej-stencel
approved these changes
Feb 5, 2024
MovieStoreGuy
approved these changes
Feb 6, 2024
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…1038) **Description:** Follow up to open-telemetry/opentelemetry-collector/pull/9414, adds the same changes in `mdatagen` regarding validation of `component.Type`s. On this PR the validation logic and templating is a bit more complex because of subcomponents. I will add these changes back on core once this PR is merged. **Link to tracking Issue:** open-telemetry/opentelemetry-collector/issues/9208
mx-psi
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 6, 2024
**Description:** Follow up to #9414 and open-telemetry/opentelemetry-collector-contrib/pull/31038. **Link to tracking Issue:** Fixes #9208.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to open-telemetry/opentelemetry-collector/pull/9414, adds the same changes in
mdatagenregarding validation ofcomponent.Types.On this PR the validation logic and templating is a bit more complex because of subcomponents. I will add these changes back on core once this PR is merged.
Link to tracking Issue: open-telemetry/opentelemetry-collector/issues/9208