Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Add support for component.UseLocalHostAsDefaultHost #27439

Closed
wants to merge 19 commits into from
Closed

[all] Add support for component.UseLocalHostAsDefaultHost #27439

wants to merge 19 commits into from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 5, 2023

Description:

Add support for component.UseLocalHostAsDefaultHost feature gate in all components affected.

TODOs before marking as ready for review:

  • Discuss if healthcheck extension should also be affected
  • Check Collector helm chart to ensure we are handling things correctly for non-receiver components
  • Change wording to clarify this is about the default
  • Change port = <...> definitions by defaultPort = <...>
  • Ensure each component has a mention to the feature gate on their README

Depends on open-telemetry/opentelemetry-collector/pull/8622.

Link to tracking Issue: Updates open-telemetry/opentelemetry-collector/issues/8510

@mx-psi
make for-all CMD="go mod edit -replace go.opentelemetry.io/collector/…
f3f5dfe 
…component=github.com/mx-psi/opentelemetry-collector/component@8f14eb08185e853484c042f951219b5af90c0814" && make gotidy
@mx-psi
[receiver/jmx] Support component.UseLocalHostAsDefaultHost
eaedf9d
@mx-psi
[extension/awsproxy] Add support for component.UseLocalHostAsDefaultHost
8bef435
@mx-psi
[receiver/loki] Add support component.UseLocalHostAsDefaultHost
1d45966
@mx-psi
[receiver/jaeger] Add support for component.UseLocalHostAsDefaultHost
8b99cb0
@mx-psi
[receiver/zipkin] Add support for component.UseLocalHostAsDefaultHost
938cb18
@mx-psi
[receiver/awsxray] Add support for component.UseLocalHostAsDefaultHost
10a11d8
@mx-psi
[receiver/influxdbreceiver] Add support for component.UseLocalHostAsD…
674edef 
…efaultHost
@mx-psi
[receiver/awsfirehose] Add support for component.UseLocalHostAsDefaul…
76e6363 
…tHost
@mx-psi
[receiver/opencensus] Add support for component.UseLocalHostAsDefault…
b05009e 
…Host
@mx-psi
[receiver/skywalking] Add support for component.UseLocalHostAsDefault…
828ed19 
…Host
@mx-psi
[extension/jaegerrremotesampling] Add support for component.UseLocalH…
4e6d80f 
…ostAsDefaultHost
@mx-psi
[receiver/zookeeper] Add support for component.UseLocalHostAsDefaultHost
f4bb07e
@mx-psi
[extension/httpforwarder] Add support for component.UseLocalHostAsDef…
e0a8c20 
…aultHost
@mx-psi
[processor/remoteobserver] Add support for component.LocalHostAsDefau…
5f2228e 
…ltHost
@mx-psi
[receiver/sapm] Add support for component.UseLocalHostAsDefaultHost
5e7c11b
@mx-psi
[receiver/signalfx] Add support for component.UseLocalHostAsDefaultHost
73a1588
@mx-psi
[receiver/splunkhec] Add support for component.UseLocalHostAsDefaultHost
77c331a
@mx-psi
Add changelog entry
a41b2f5
@mx-psi mx-psi mentioned this pull request Oct 5, 2023
Merged
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 20, 2023
@mx-psi mx-psi removed the Stale label Oct 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski will be requested when the pull request is marked ready for review djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy will be requested when the pull request is marked ready for review MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel will be requested when the pull request is marked ready for review andrzej-stencel is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 will be requested when the pull request is marked ready for review crobert-1 is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme will be requested when the pull request is marked ready for review atoulme is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd will be requested when the pull request is marked ready for review jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax will be requested when the pull request is marked ready for review dmitryax is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten will be requested when the pull request is marked ready for review codeboten is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 will be requested when the pull request is marked ready for review fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling will be requested when the pull request is marked ready for review jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 will be requested when the pull request is marked ready for review Aneurysm9 is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth will be requested when the pull request is marked ready for review TylerHelmuth is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro will be requested when the pull request is marked ready for review yurishkuro is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu will be requested when the pull request is marked ready for review bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley will be requested when the pull request is marked ready for review evan-bradley is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth will be requested when the pull request is marked ready for review jsuereth is a code owner

@songy23 songy23 Awaiting requested review from songy23 songy23 will be requested when the pull request is marked ready for review songy23 is a code owner

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar bryan-aguilar will be requested when the pull request is marked ready for review bryan-aguilar is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan will be requested when the pull request is marked ready for review tigrannajaryan is a code owner

Assignees
No one assigned
Labels
cmd/configschema configschema command cmd/githubgen cmd/mdatagen mdatagen command cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command confmap/provider/s3provider connector/count connector/datadog connector/exceptions connector/routing connector/servicegraph connector/spanmetrics examples/demo exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/dynatrace exporter/elasticsearch exporter/f5cloud F5 exporter exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/influxdb exporter/instana exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/parquet exporter/prometheus exporter/prometheusremotewrite exporter/pulsar Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mx-psi