Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v0.62.0 release #6603

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Prepare v0.62.0 release #6603

merged 1 commit into from
Feb 29, 2024

Conversation

ashutosh-narkar
Copy link
Member

No description provided.

@ashutosh-narkar
Copy link
Member Author

On the Netlify failure, the log says

3:43:16 PM: # github.com/prometheus/common/model
3:43:16 PM: vendor/github.com/prometheus/common/model/metric.go:363:33: undefined: strings.CutPrefix
3:43:16 PM: note: module requires Go 1.20

I'll investigate that.

johanfylling
johanfylling previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md
- docs: Use `application/yaml` instead of `application/x-yaml` as the former is now a recognized content type ([#6565](https://github.com/open-policy-agent/opa/pull/6565)) authored by @anderseknert

### Miscellaneous
- Add Elastic to ADOPTERS.md ([#6568](https://github.com/open-policy-agent/opa/pull/6568)) authored by @orouz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong under the Docs + Website + Ecosystem section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopter file changes have been in the Miscellaneous section sometimes and Docs in some cases so just added in Miscellaneous.

@ashutosh-narkar
Copy link
Member Author

Seems to be an issue with the Go version in the Netlify runner. From the logs

3:40:35 PM: Installing Go version 1.22 (requested 1.22)
3:40:35 PM: Failed to install Go version "1.22"
3:40:36 PM: Continue with existing version "1.19.13"

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024

✅ Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 678b357
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/65dfd334d4d1a60008b25edd
😎 Deploy Preview https://deploy-preview-6603--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ashutosh-narkar
ashutosh-narkar commented Feb 29, 2024
View reviewed changes
.go-version Outdated
@@ -1 +1 @@
1.22
1.21.5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to make Netlify builds pass as there seem to be failures while installing Go v1.22 and then Go v1.19 is used as a fallback. The minimum version needed to build OPA is Go v1.20

@srenatus
Copy link
Contributor

OK let's rebase this -- netlify works with 1.22 now as of #6605

@ashutosh-narkar
Prepare v0.62.0 release
b0643b4 
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar
Copy link
Member Author

OK let's rebase this -- netlify works with 1.22 now as of #6605

Done!

srenatus
srenatus approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@ashutosh-narkar ashutosh-narkar merged commit 1d0ab93 into open-policy-agent:main Feb 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenatus srenatus srenatus approved these changes

@johanfylling johanfylling johanfylling left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashutosh-narkar @srenatus @johanfylling