topdown/http: Respect raise_error flag during input validation #6553
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Is this change in response to a raised user issue?
Naïvely, I'd expected raise_error to only affect issues when making the HTTP call, and not to function argument validation. I.e. any error in the argument that can be detected before a call is made would always raise an error, regardless of the value of raise_error, as this would more likely fall within the categories of programmer- or configuration error.
I see, however, that this isn't the precedence, as e.g. force_cache_duration_seconds/force_cache error reporting already is affected by raise_error.
|
I agree with @johanfylling — I would not expect |
Currently the `raise_error` flag is not honored during the input validation step. So `http.send` will return an error if input validation fails irrespective of the `raise_error` flag status. This change attempts to fix that. Also the description of the `raise_error` flag is updated to reflect actual behavior. Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar
force-pushed
the
fix-http-send-in-vali
branch
from
3cd4f59
to
8a8b9ff
Compare
Why the changes in this PR are needed?
Currently the
raise_errorflag is not honored during the input validation step. Sohttp.sendwill return an error if input validation fails irrespective of theraise_errorflag status.What are the changes in this PR?
This change takes into account
raise_errorflag status during the input validation phase.Further comments:
The description of the
raise_errorflag is updated to reflect actual behavior.