Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency-management-data logo #6543

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jamietanna
Copy link
Contributor

Why the changes in this PR are needed?

Now we've got a logo for the project, we should use it!

What are the changes in this PR?

Notes to assist PR review:

Further comments:

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit c343883
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/65b14f9c561c3500080fc52c
😎 Deploy Preview https://deploy-preview-6543--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@charlieegan3
Copy link
Contributor

Hi Jamie, this looks good to me. the preview is a little funny at https://deploy-preview-6543--openpolicyagent.netlify.app/integrations/dependency-management-data/, but we need to address that with CSS rather than in the PR.

Can you rebase and sign off the commit for the DCO check? then we can get this in.

@charlieegan3
Copy link
Contributor

p.s. the new logo is ✨ ! I like it!

Now we've got one, we should use it!

Signed-off-by: Jamie Tanna <jamie@jamietanna.co.uk>
@jamietanna
Copy link
Contributor Author

Thanks very much, very happy with it and the designer who did it 😄

Ah yes, that looks interesting 😅

@charlieegan3 charlieegan3 merged commit dd0e198 into open-policy-agent:main Jan 24, 2024
25 checks passed
charlieegan3 added a commit to charlieegan3/opa that referenced this pull request Jan 24, 2024
Issue identified in open-policy-agent#6543

Signed-off-by: Charlie Egan <charlie@styra.com>
@charlieegan3
Copy link
Contributor

Thanks for the prompt rebase, I should have a fix in #6544

charlieegan3 added a commit that referenced this pull request Jan 24, 2024
Issue identified in #6543

Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants