docs: update version for non docs pages #6526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the default version for all non docs pages to latest. We have recently started to list some pages in the search index from non docs pages, when a user makes a search, they search within the current version. This will make pages from the rest of the site available in the index when searching from 'latest'. Signed-off-by: Charlie Egan <charlie@styra.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srenatus
approved these changes
Jan 16, 2024
ashutosh-narkar
approved these changes
Jan 16, 2024
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 17, 2024
open-policy-agent#6526 contained two errors, that I can see. First, it used `Permalink` rather than `RelPermalink`, this contains the host and scheme on build and so the older versions of pages were all getting version set to the latest. Even if that had worked, the setting of version was incorrect and set a locally scoped var instead of the variable for the whole file. Signed-off-by: Charlie Egan <charlie@styra.com>
ashutosh-narkar
pushed a commit
that referenced
this pull request
Jan 17, 2024
#6526 contained two errors, that I can see. First, it used `Permalink` rather than `RelPermalink`, this contains the host and scheme on build and so the older versions of pages were all getting version set to the latest. Even if that had worked, the setting of version was incorrect and set a locally scoped var instead of the variable for the whole file. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default version for all non docs pages to latest.
We have recently started to list some pages in the search index from non docs pages, when a user makes a search, they search within the current version. This will make pages from the rest of the site available in the index when searching from 'latest'.