Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explain %T behavior of sprintf #6492

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Dec 18, 2023

Why the changes in this PR are needed?

Using the sprintf function to evaluate the type of a certain value, the current implementation is likely to cause confusion.

What are the changes in this PR?

Clarify some of the intricacies when using sprintf.

Notes to assist PR review:

See additional context in #6487

Fixes open-policy-agent#6487

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 6fc8877
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/6580b241ce704800089c7b74
😎 Deploy Preview https://deploy-preview-6492--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Ideally we'd expand on this with other quirks originating from sprintf, but that can be done later. This solves the issue as reported, so 👍 from me.

@ashutosh-narkar ashutosh-narkar merged commit ba46112 into open-policy-agent:main Dec 18, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants