Fix a typo in _index.md #6491
Fix a typo in _index.md #6491
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -1002,7 +1002,7 @@ opa run example.rego repl.input:input.json | |||
| ``` | |||
|
|
|||
| ```ruby | |||
| > data.example.public_server[s] | |||
| > data.example.public_servers[s] | |||
There was a problem hiding this comment.
The rule is defined as public_server here, though: https://github.com/open-policy-agent/opa/pull/6491/files#diff-5d9ba8bc1a568741b44ccc852748ca739d71f89dc1ac05a9f8d3787a064a549dR907
So either we keep it as-is, or change both locations (and perhaps others, if there are any).
|
@trungnguyen thanks for working on this. If you can address Stephan's comments above that would be great. Thanks! |
docs/content/_index.md
Outdated
| @@ -904,7 +904,7 @@ violation contains server.id if { # a server is in the violati | |||
| server.protocols[_] == "telnet" # it contains the "telnet" protocol. | |||
| } | |||
|
|
|||
| public_server contains server if { # a server exists in the public_server set if... | |||
| public_servers contains server if { # a server exists in the public_servers set if... | |||
There was a problem hiding this comment.
This is called earlier in the policy. So we would need to update that too.
|
Thanks for the changes @trungnguyen! Can you please squash your commits and sign them off and we can get this in. See this reference for authoring a good commit message. |
trungnguyen
force-pushed
the
patch-1
branch
2 times, most recently
from
3a655ae
to
1bb8572
Compare
ashutosh-narkar
force-pushed
the
patch-1
branch
from
1bb8572
to
73b8307
Compare
trungnguyen
force-pushed
the
patch-1
branch
2 times, most recently
from
65cf436
to
c49af54
Compare
Signed-off-by: Trung Nguyen <nghotr@yahoo.com>
missing 's' in the word 'public_server' in the code below data.example.public_server[s]
Why the changes in this PR are needed?
What are the changes in this PR?
Notes to assist PR review:
Further comments: