feat: Support raising builtin errors in the test runner #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jalseth
force-pushed
the
tester-builtin-errors
branch
from
f3a1dae
to
544ab44
Compare
It can be useful to know if Rego unit tests fail due to logic errors, or if a builtin raised an error, such as parsing JSON input that was typo'd. Signed-off-by: James Alseth <james@jalseth.me>
ashutosh-narkar
force-pushed
the
tester-builtin-errors
branch
from
544ab44
to
d160fd4
Compare
| if len(builtinErrors) == 1 { | ||
| tr.Error = &builtinErrors[0] | ||
| } else { | ||
| tr.Error = fmt.Errorf("%v", builtinErrors) |
There was a problem hiding this comment.
Nit: We could add a test case to exercise this path but seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to know if Rego unit tests fail due to logic errors, or if a builtin raised an error, such as parsing JSON input that was typo'd.
Fixes #6489.