Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --v1-compatible flag to opa build and opa eval #6478

Merged
merged 21 commits into from
Dec 20, 2023
Merged

Adding --v1-compatible flag to opa build and opa eval #6478

merged 21 commits into from
Dec 20, 2023

Commits on Dec 19, 2023

  1. ast+cmd+rego: Adding --rego-v1 flag to opa eval 

    Fixes: open-policy-agent#6463
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    6808e80 View commit details
    Browse the repository at this point in the history

  2. Adding --rego-v1 flag to opa build 

    Fixes: open-policy-agent#6463
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    56b1e54 View commit details
    Browse the repository at this point in the history

  3. Formatting PE support modules to comply with rego-v1 when required 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    45e5fdb View commit details
    Browse the repository at this point in the history

  4. Removing rego.v1 import when formatting for rego-v1 (not rego-v0-comp… 

    …at-v1)

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    44e6772 View commit details
    Browse the repository at this point in the history

  5. touch up 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    3da495e View commit details
    Browse the repository at this point in the history

  6. Fixing linting issues 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e38eb8a View commit details
    Browse the repository at this point in the history

  7. Consolidating Bundle.FormatModules() and `Bundle.FormatModulesForRe… 

    …goVersion()`

Suggested by @ashutosh-narkar

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    46db9c2 View commit details
    Browse the repository at this point in the history

  8. Adding descriptions to RegoVersion 

    Requested by @ashutosh-narkar

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1b2e632 View commit details
    Browse the repository at this point in the history

  9. Using --v1-compatible flag instead of --rego-v1 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a8e033b View commit details
    Browse the repository at this point in the history

  10. Updating docs 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling @ashutosh-narkar
    johanfylling authored and ashutosh-narkar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b811b7b View commit details
    Browse the repository at this point in the history

  11. Reintroducing ParserOptions.RegoV1Compatible to avoid breaking change 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b9559ad View commit details
    Browse the repository at this point in the history

  12. cmd & tester 

    Adding `--v1-compatible` flag to `opa test`

Fixes: open-policy-agent#6463
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    326e873 View commit details
    Browse the repository at this point in the history

  13. Adding --v1-compatible flag to opa fmt 

    Fixes: open-policy-agent#6463
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d818bd7 View commit details
    Browse the repository at this point in the history

  14. Adding --v1-compatible flag to opa check 

    Fixes: open-policy-agent#6463
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fdc4db6 View commit details
    Browse the repository at this point in the history

  15. Making linter happy 

    Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    93462a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Review modifications suggested by @ashutosh-narkar 

    * Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d248201 View commit details
    Browse the repository at this point in the history

  2. Review modifications suggested by @ashutosh-narkar 

    * Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description
* Adding back `Opts.RegoV1` and deprecating.
  * Making `Opts.RegoV1` take precedence over `Opts.RegoVersion`

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1e63193 View commit details
    Browse the repository at this point in the history

  3. Review modifications suggested by @ashutosh-narkar 

    * Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description
* Adding back `Opts.RegoV1` and deprecating.
  * Making `Opts.RegoV1` take precedence over `Opts.RegoVersion`
* `TestPartialWitRegoV1` -> `TestPartialWithRegoV1`

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c5cde1d View commit details
    Browse the repository at this point in the history

  4. Review modifications suggested by @ashutosh-narkar 

    * Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description
* Adding back `Opts.RegoV1` and deprecating.
  * Making `Opts.RegoV1` take precedence over `Opts.RegoVersion`
* `TestPartialWitRegoV1` -> `TestPartialWithRegoV1`
* removing `Println` in test

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e9ff76c View commit details
    Browse the repository at this point in the history

  5. Review modifications suggested by @ashutosh-narkar 

    * Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description
* Adding back `Opts.RegoV1` and deprecating.
  * Making `Opts.RegoV1` take precedence over `Opts.RegoVersion`
* `TestPartialWitRegoV1` -> `TestPartialWithRegoV1`
* removing `Println` in test
* Updating docs with per-command behavioural descriptions for `--v1-compatible`.

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    839fe01 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into rego-v1/flag_on_all_commands

    @johanfylling
    johanfylling committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e5a5558 View commit details
    Browse the repository at this point in the history