server: Use tlsConfigMtx when accessing certpool #6477
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
changed the title
This was missed in open-policy-agent#6415 https://github.com/open-policy-agent/opa/actions/runs/7194437460/job/19595009978?pr=6476 We have a warning of this data race here: ``` ================== WARNING: DATA RACE Write at 0x00c009b562e8 by goroutine 1815: github.com/open-policy-agent/opa/server.(*Server).reloadTLSConfig() /src/server/certs.go:65 +0x608 github.com/open-policy-agent/opa/server.(*Server).getListener.(*Server).certLoopNotify.func2() /src/server/certs.go:174 +0x434 github.com/open-policy-agent/opa/server.TestCertPoolReloading.func1() /src/server/server_test.go:5105 +0x4f github.com/open-policy-agent/opa/server.TestCertPoolReloading.func2() /src/server/server_test.go:5108 +0x41 Previous read at 0x00c009b562e8 by goroutine 1824: github.com/open-policy-agent/opa/server.(*Server).getListenerForHTTPSServer.func1() /src/server/server.go:649 +0x145 crypto/tls.(*Conn).readClientHello() /usr/local/go/src/crypto/tls/handshake_server.go:149 +0x97d crypto/tls.(*Conn).serverHandshake() /usr/local/go/src/crypto/tls/handshake_server.go:42 +0x64 crypto/tls.(*Conn).serverHandshake-fm() <autogenerated>:1 +0x47 crypto/tls.(*Conn).handshakeContext() /usr/local/go/src/crypto/tls/conn.go:1552 +0x615 crypto/tls.(*Conn).HandshakeContext() /usr/local/go/src/crypto/tls/conn.go:1492 +0x16b8 net/http.(*conn).serve() /usr/local/go/src/net/http/server.go:1891 +0x16c0 net/http.(*Server).Serve.func3() /usr/local/go/src/net/http/server.go:3086 +0x4f ``` Signed-off-by: Charlie Egan <charlie@styra.com>
ashutosh-narkar
force-pushed
the
use-mutex-access-certpool
branch
from
608349c
to
3f23d08
Compare
ashutosh-narkar
approved these changes
Dec 13, 2023
|
Thanks Ash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #6415
https://github.com/open-policy-agent/opa/actions/runs/7194437460/job/19595009978?pr=6476
We have a warning of this data race here: