ast+cmd: Allowing bundle to contain calls to unknown functions when inspected #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanfylling
commented
Dec 7, 2023
|
|
||
| bs := out.Bytes() | ||
| output := strings.TrimSpace(string(bs)) | ||
| // Note: unknown foo.bar() built-in doesn't appear in the output, but also didn't cause an error. |
There was a problem hiding this comment.
We've taken care of the bug that will opa inspect fail with an error.
As a possible improvement, we could also include the unknown function in the capabilities/builtins listing. We wouldn't know the types other than what's in the call, though, so I think we'd need to set the result and args types to any.
The question is if this would be helpful or confusing to the user.
…nspected Fixes: open-policy-agent#6457 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
ashutosh-narkar
force-pushed
the
cmd/inspect_unknown_funcs
branch
from
7377f1e
to
1e4d3e3
Compare
anderseknert
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6457