Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve user provided http headers in aws.sign_req #6456

Merged
merged 1 commit into from Dec 12, 2023
Merged

Preserve user provided http headers in aws.sign_req #6456

merged 1 commit into from Dec 12, 2023

Commits on Dec 5, 2023

  1. Preserve user provided http headers in aws.sign_req 

    Currently while all the headers are signed the headers in the
returned object are missing all the original user provided headers
This means that if you pass the object directly to http.send
amazon will fail the request because the signed data doesn't match
the canonical request. Users can work around it by using object.union
to restore the original headers, but would be nice to avoid that extra
step

Signed-off-by: Peter <c2zwdjnlcg@users.noreply.github.com>
    @c2zwdjnlcg
    c2zwdjnlcg committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    51b8293 View commit details
    Browse the repository at this point in the history