cmd: removes hidden dependency on diff command #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces call to local diff command as a hidden dependency with call to go-diff, which is already included in the repo. Fixes open-policy-agent#6284 Signed-off-by: Colin Lacy <colinjlacy@gmail.com>
Signed-off-by: Colin Lacy <colinjlacy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
There's a hidden dependency on the
diffcommand, which can fail if there is no diff tool installed.What are the changes in this PR?
diffwith a call to the go-diff library, which is already installedformatFilefunction to improve coverageFurther comments:
I wanted to add more tests to continue to improve coverage, specifically for the
-wflag, but that's beyond the scope of this issue and would have taken some lengthy digging into theutil/testpackage. Is there a general coverage improvement issue that can be used for things like that?Fixes #6284