New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General refs/planner #6235
Merged
johanfylling
merged 10 commits into
open-policy-agent:main
from
johanfylling:general_refs/planner
Sep 27, 2023
Merged
General refs/planner #6235
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a666999
planner: Adding support for general ref rule heads
johanfylling 51c835a
Disallowing rules from overriding and injecting into values defined b…
johanfylling 9e8db43
Support set leafs
johanfylling ef72c6b
Merge branch 'main' into general_refs/planner
johanfylling 1ae1d1e
Fixing issue where not all set leaf rules were captured by dynamic po…
johanfylling 3d14a57
Updating tests
johanfylling 0a16968
Merge branch 'main' into general_refs/planner
johanfylling 114a06a
Merge branch 'main' into general_refs/planner
johanfylling b71fdb5
Fixing issues found by @srenatus
johanfylling b59b673
Merge branch 'main' into general_refs/planner
johanfylling File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
test/cases/testdata/partialobjectdoc/test-partialobjectdoc-ref.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
cases: | ||
- note: partialobjectdoc/ref | ||
modules: | ||
- | | ||
package generated | ||
|
||
p.q[k] = v { | ||
k := ["foo", "bar"][v] | ||
} | ||
|
||
# p.baz := 2 | ||
srenatus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
q { | ||
x := "bar" | ||
y := "q" | ||
p[y][x] == 1 | ||
} | ||
|
||
query: data.generated.q = x | ||
want_result: | ||
- x: | ||
true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 But let's also remove the comments 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I totally forgot about those 😅. Will remove 👍.