build: update .go-version to unblock netlify build #6605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/netlify-golang-version
branch
2 times, most recently
from
14c01ac
to
d7297e0
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srenatus
changed the title
Signed-off-by: Stephan Renatus <stephan@styra.com>
srenatus
force-pushed
the
sr/netlify-golang-version
branch
from
d7297e0
to
751263a
Compare
tsidebottom
pushed a commit
to tsidebottom/opa-
that referenced
this pull request
Apr 17, 2024
…#6605) With .go-version containing 1.22, netlify fails to pick up the golang binary: 9:32:09 AM: Installing Go version 1.22 (requested 1.22) 9:32:09 AM: Failed to install Go version "1.22" 9:32:12 AM: Continue with existing version "1.19.13" and the build breaks with 1.19.x. Setting .go-version to 1.22.0 (with .0 at the end) matches the versioning scheme on https://go.dev/dl/, and it seems to succeed picking up the right go version for the website build: 9:33:35 AM: Installing Go version 1.22.0 (requested 1.22.0) 9:33:37 AM: go version go1.22.0 linux/amd64 Signed-off-by: Stephan Renatus <stephan@styra.com> Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
.go-versioncontaining 1.22, netlify fails to pick up the golang binary:and the build breaks with 1.19.x.
Setting
.go-versionto 1.22.0 (with .0 at the end) matches the versioning scheme on https://go.dev/dl/, and it seems to succeed picking up the right go version for the website build: