Skip to content

Commit

Permalink
Review modifications suggested by @ashutosh-narkar
Browse files Browse the repository at this point in the history
* Changing `ParserOptions.RegoV1Compatible` take precedence over `ParserOptions.RegoVersion`
* Fixing comment in test
* Updating `fmt --rego-v1` CLI description
* Adding back `Opts.RegoV1` and deprecating.
  * Making `Opts.RegoV1` take precedence over `Opts.RegoVersion`
* `TestPartialWitRegoV1` -> `TestPartialWithRegoV1`
* removing `Println` in test

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
  • Loading branch information
johanfylling committed Dec 20, 2023
1 parent c5cde1d commit e9ff76c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions rego/rego_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1229,8 +1229,6 @@ foo[__local1__1] { __local1__1 = input.v }`,
t.Fatal(err)
}

fmt.Println(partialQuery)

actualQuery := partialQuery.Queries[0].String()
if tc.expQuery != actualQuery {
t.Fatalf("Expected partial query to be:\n\n%s\n\nbut got:\n\n%s", tc.expQuery, actualQuery)
Expand Down

0 comments on commit e9ff76c

Please sign in to comment.