Skip to content

Commit

Permalink
fix(oci): adjust to pr review
Browse files Browse the repository at this point in the history
Signed-off-by: slonka <slonka@users.noreply.github.com>
  • Loading branch information
slonka committed Feb 7, 2024
1 parent d95f2d1 commit 677fdd8
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 28 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- os: linux
run: ubuntu-22.04
targets: ci-go-ci-build-linux-static
go_tags: opa_no_oci
go_tags: GO_TAGS="-tags=opa_no_oci"
arch: arm64
- os: windows
run: ubuntu-22.04
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
name: generated

- name: Build
run: make GO_TAGS="-tags=${{ matrix.go_tags }}" ${{ matrix.targets }}
run: make ${{ matrix.go_tags }} ${{ matrix.targets }}
env:
GOARCH: ${{ matrix.arch }}
timeout-minutes: 30
Expand Down
2 changes: 0 additions & 2 deletions download/oci_download.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import (
"github.com/open-policy-agent/opa/util"
)

var _ OCIDownloaderInterface = (*OCIDownloader)(nil)

// NewOCI returns a new Downloader that can be started.
func NewOCI(config Config, client rest.Client, path, storePath string) *OCIDownloader {
localstore, err := oci.New(storePath)
Expand Down
22 changes: 0 additions & 22 deletions download/oci_download_interface.go

This file was deleted.

2 changes: 0 additions & 2 deletions download/oci_download_unavailable.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import (
"github.com/open-policy-agent/opa/plugins/rest"
)

var _ OCIDownloaderInterface = (*OCIDownloader)(nil)

func NewOCI(Config, rest.Client, string, string) *OCIDownloader {
panic("built without OCI support")
}
Expand Down

0 comments on commit 677fdd8

Please sign in to comment.