🐛 Skip health check for deployments whose replicas is 0 #279
Conversation
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
health-probe-replica
branch
from
83f320a to
6bd739a
Compare
|
/hold |
|
/hold cancel |
|
/cherrypick release-0.10 |
|
@zhujian7: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ba7fd00
into
open-cluster-management-io:main
|
@zhujian7: new pull request created: #280 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
In some cases, we want to deploy a deployment resource whose replicas is 0 to the managed cluster, if we set the health probe type to "WorkloadAvailability", the addon can not become available since there is no probed result for 0 replicas deployments. In this situation, we want to make the health probe check pass for the addon.
Related issue(s)
Fixes #