Support for bfloat16 for binary, unary operators in reference implementation #6166
+170
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
justinchuby
reviewed
Jun 10, 2024
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6166 +/- ##
==========================================
+ Coverage 56.95% 57.24% +0.28%
==========================================
Files 506 506
Lines 30467 31036 +569
Branches 4592 4614 +22
==========================================
+ Hits 17353 17766 +413
- Misses 12285 12446 +161
+ Partials 829 824 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
|
What will What about [TENSOR_TYPE_MAP] ( Line 21 in 88f8ef1 Related bug in onnxscript: microsoft/onnxscript#1543 |
|
Let me create another PR for this one. My change only use mk_dtypes to support binary operations but it does not change the custom dtype used to carry type information in numpy. We can do that as well but we need to decide first if we want to add ml_dtypes as a mandatory dependency. |
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
justinchuby
reviewed
Jun 13, 2024
justinchuby
reviewed
Jun 13, 2024
justinchuby
reviewed
Jun 13, 2024
justinchuby
reviewed
Jun 13, 2024
justinchuby
reviewed
Jun 13, 2024
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
gramalingam
reviewed
Jun 17, 2024
gramalingam
approved these changes
Jun 17, 2024
justinchuby
reviewed
Jun 17, 2024
gramalingam
approved these changes
Jun 20, 2024
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
…ntation (onnx#6166) ### Description Supports bfloat16 binary, unary operations if ml_dtypes is installed. Partially answer onnx#6151. ### Motivation and Context numpy does not support bfloat16 natively but pytorch or tensorflow does. The reference implementation should support that as well. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
…ntation (onnx#6166) ### Description Supports bfloat16 binary, unary operations if ml_dtypes is installed. Partially answer onnx#6151. ### Motivation and Context numpy does not support bfloat16 natively but pytorch or tensorflow does. The reference implementation should support that as well. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports bfloat16 binary, unary operations if ml_dtypes is installed. Partially answer #6151.
Motivation and Context
numpy does not support bfloat16 natively but pytorch or tensorflow does. The reference implementation should support that as well.