Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for rel-1.16.0 #5947

Closed
wants to merge 2 commits into from
Closed

Conversation

cjvolzka
Copy link
Contributor

Description

prepare for rel-1.16.0 branch cut (planned for 02/26 https://github.com/onnx/onnx/wiki/Logistics-for-ONNX-Release-1.16.0)

Motivation and Context

ONNX 1.16.0 is planned to be released on 3/18

### Description
prepare for rel-1.16.0 branch cut (planned for 02/26 https://github.com/onnx/onnx/wiki/Logistics-for-ONNX-Release-1.16.0)

### Motivation and Context
ONNX 1.16.0 is planned to be released on 3/18

Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
@cjvolzka cjvolzka added this to the 1.16 milestone Feb 19, 2024
@cjvolzka cjvolzka requested review from a team as code owners February 19, 2024 21:55
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.68%. Comparing base (9140ca7) to head (d18e2f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5947   +/-   ##
=======================================
  Coverage   56.68%   56.68%           
=======================================
  Files         506      506           
  Lines       30227    30229    +2     
  Branches     4565     4565           
=======================================
+ Hits        17133    17135    +2     
  Misses      12268    12268           
  Partials      826      826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjvolzka cjvolzka closed this Feb 22, 2024
@cjvolzka cjvolzka reopened this Feb 22, 2024
@cjvolzka
Copy link
Contributor Author

@liqunfu would you be able to help me understand why the tests are failing? Did I miss something updating the versions/opsets?

@cjvolzka
Copy link
Contributor Author

I was finally able to figure out how to replicate the build failure locally. It appears prep changes caused the TreeEnsemble test model to get updated for IR 10 in addition to ai.onnx.ml 5 and a git diff test was tripping on it.

For some reason, the CI isn't starting after I pushed a commit to address the issue. I'm closing this PR and will continue from #5959 instead.

@cjvolzka cjvolzka closed this Feb 23, 2024
@cjvolzka cjvolzka deleted the prepare-for-rel-1.16.0 branch March 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant