-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser/printer support external data format #5688
Parser/printer support external data format #5688
Commits on Oct 22, 2023
-
Extract StringStringEntry parse function
Refactoring for the following external data format support. Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for fa4e326 - Browse repository at this point
Copy the full SHA fa4e326View commit details -
Implement parser / printer for external data
- Parse initializer starts with "=[" for external data - Print initializer starts with "=[" for external data - Add unit test Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 8850ae7 - Browse repository at this point
Copy the full SHA 8850ae7View commit details -
Fix python.md textual format example
The string should use double quote, not single quote. Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 43444e6 - Browse repository at this point
Copy the full SHA 43444e6View commit details -
Update ONNX textual syntax for external data
Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 93a7755 - Browse repository at this point
Copy the full SHA 93a7755View commit details -
Update TODO comment, external data is supported
Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for a2adc73 - Browse repository at this point
Copy the full SHA a2adc73View commit details -
Remove onnx:: namespace qualifier
We cannot reference the onnx:: namespace directly because it is compile time defined (users can choose to call it differently). Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 36449d3 - Browse repository at this point
Copy the full SHA 36449d3View commit details -
Fix coding style according to lint
Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 8535d99 - Browse repository at this point
Copy the full SHA 8535d99View commit details -
Improve parser / printer, and document
- While print, check if the external data format is specified before the internall data. Theoratically they are mutually exclusize, however, during some conversion internal state, the external and internal might be specified at the same time. In that case, we want to print the external data format. - Replace Parse with PARSE macro, apply check automatically. - Update document, add the definition of str-str. Signed-off-by: yoco <yoco@skymizer.com>
Configuration menu - View commit details
-
Copy full SHA for 0083c24 - Browse repository at this point
Copy the full SHA 0083c24View commit details
Commits on Oct 24, 2023
-
Merge branch 'main' into feature/parser-support-external-data-format
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6e6edd7 - Browse repository at this point
Copy the full SHA 6e6edd7View commit details