Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser/printer support external data format #5688

Merged

Commits on Oct 22, 2023

  1. Extract StringStringEntry parse function

    Refactoring for the following external data format support.
    
    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    fa4e326 View commit details
    Browse the repository at this point in the history
  2. Implement parser / printer for external data

    - Parse initializer starts with "=[" for external data
    - Print initializer starts with "=[" for external data
    - Add unit test
    
    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    8850ae7 View commit details
    Browse the repository at this point in the history
  3. Fix python.md textual format example

    The string should use double quote, not single quote.
    
    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    43444e6 View commit details
    Browse the repository at this point in the history
  4. Update ONNX textual syntax for external data

    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    93a7755 View commit details
    Browse the repository at this point in the history
  5. Update TODO comment, external data is supported

    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a2adc73 View commit details
    Browse the repository at this point in the history
  6. Remove onnx:: namespace qualifier

    We cannot reference the onnx:: namespace directly
    because it is compile time defined (users can choose to
    call it differently).
    
    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    36449d3 View commit details
    Browse the repository at this point in the history
  7. Fix coding style according to lint

    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    8535d99 View commit details
    Browse the repository at this point in the history
  8. Improve parser / printer, and document

    - While print, check if the external data format is specified before the
      internall data. Theoratically they are mutually exclusize, however,
      during some conversion internal state, the external and internal might
      be specified at the same time. In that case, we want to print the
      external data format.
    - Replace Parse with PARSE macro, apply check automatically.
    - Update document, add the definition of str-str.
    
    Signed-off-by: yoco <yoco@skymizer.com>
    yocosky committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0083c24 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge branch 'main' into feature/parser-support-external-data-format

    Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
    justinchuby committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6e6edd7 View commit details
    Browse the repository at this point in the history