Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backward conversions from 18->17 for reduce ops #5606

Merged
merged 20 commits into from
Sep 26, 2023
+201 −98
Merged

Add backward conversions from 18->17 for reduce ops #5606

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4389372
reduceOps has missing backward conversions from 18->17
liqunfu Sep 20, 2023
4dfdc89
18->17
liqunfu Sep 20, 2023
f0cf5bd
add reduce op downgrade tests
liqunfu Sep 20, 2023
a9c0a13
use automatic_conversion_test_base.py
liqunfu Sep 20, 2023
27fa956
lint
liqunfu Sep 20, 2023
bb2f7ba
lint
liqunfu Sep 20, 2023
ab78087
lt
liqunfu Sep 21, 2023
c769503
only import modules
liqunfu Sep 21, 2023
b21fb5a
module import
liqunfu Sep 21, 2023
b9aba8e
Merge branch 'main' into liqun/reduce-convert-18-17
liqunfu Sep 21, 2023
a951a6d
Update onnx/test/automatic_downgrade_test.py
liqunfu Sep 22, 2023
ce4e828
Update onnx/test/automatic_downgrade_test.py
liqunfu Sep 22, 2023
0b8126d
Update onnx/test/automatic_downgrade_test.py
liqunfu Sep 22, 2023
b3f7fbc
Update onnx/test/automatic_downgrade_test.py
liqunfu Sep 22, 2023
42004da
@
liqunfu Sep 22, 2023
0d3a1de
doc
liqunfu Sep 22, 2023
614f394
Update onnx/test/automatic_conversion_test_base.py
justinchuby Sep 22, 2023
385f538
add version_converter folder
liqunfu Sep 22, 2023
c0d0e2b
update with reviewer's comments
liqunfu Sep 26, 2023
814b0cb
Merge branch 'main' into liqun/reduce-convert-18-17
liqunfu Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions onnx/test/automatic_downgrade_test.py
View file
Open in desktop
liqunfu marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
import numpy as np
from automatic_conversion_test_base import TestAutomaticConversion
liqunfu marked this conversation as resolved.
Show resolved Hide resolved

from onnx import TensorProto, helper
import onnx
Fixed Show fixed Hide fixed
Fixed Show fixed Hide fixed
from onnx import helper

#####################################################################################
# Every test calls _test_op_conversion to downgrade a model from the most recent opset version
Expand All @@ -18,9 +19,9 @@ class TestAutomaticDowngrade(TestAutomaticConversion):
def _test_op_downgrade(self, op, *args, **kwargs):
liqunfu marked this conversation as resolved.
Show resolved Hide resolved
self._test_op_conversion(op, *args, **kwargs, is_upgrade=False)

def test_ReduceOps(self) -> None:
def test_reduce_ops(self) -> None:
liqunfu marked this conversation as resolved.
Show resolved Hide resolved
axes = helper.make_tensor(
"b", TensorProto.INT64, dims=[3], vals=np.array([0, 1, 2])
"b", onnx.TensorProto.INT64, dims=[3], vals=np.array([0, 1, 2])
)
reduce_ops = [
"ReduceL1",
Expand All @@ -40,7 +41,7 @@ def test_ReduceOps(self) -> None:
13,
[[3, 4, 5], [3]],
[[1, 1, 1]],
[TensorProto.FLOAT, TensorProto.INT64],
[onnx.TensorProto.FLOAT, onnx.TensorProto.INT64],
initializer=[axes],
)

Expand Down