Parser/printer support external data format #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
justinchuby
reviewed
Oct 19, 2023
|
Could you fix DCO by following instructions at https://github.com/onnx/onnx/pull/5688/checks?check_run_id=17887346129 ? Thanks! cc @gramalingam |
|
Thanks for the PR & contribution! This is great to have. |
gramalingam
reviewed
Oct 20, 2023
gramalingam
reviewed
Oct 20, 2023
gramalingam
reviewed
Oct 20, 2023
gramalingam
reviewed
Oct 20, 2023
gramalingam
reviewed
Oct 20, 2023
Refactoring for the following external data format support. Signed-off-by: yoco <yoco@skymizer.com>
- Parse initializer starts with "=[" for external data - Print initializer starts with "=[" for external data - Add unit test Signed-off-by: yoco <yoco@skymizer.com>
The string should use double quote, not single quote. Signed-off-by: yoco <yoco@skymizer.com>
Signed-off-by: yoco <yoco@skymizer.com>
Signed-off-by: yoco <yoco@skymizer.com>
We cannot reference the onnx:: namespace directly because it is compile time defined (users can choose to call it differently). Signed-off-by: yoco <yoco@skymizer.com>
Signed-off-by: yoco <yoco@skymizer.com>
- While print, check if the external data format is specified before the internall data. Theoratically they are mutually exclusize, however, during some conversion internal state, the external and internal might be specified at the same time. In that case, we want to print the external data format. - Replace Parse with PARSE macro, apply check automatically. - Update document, add the definition of str-str. Signed-off-by: yoco <yoco@skymizer.com>
yocox
force-pushed
the
feature/parser-support-external-data-format
branch
from
245260a
to
0083c24
Compare
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam
approved these changes
Oct 25, 2023
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Nov 2, 2023
### Description Improve the implementation of ONNX textual printer / parser to handle external data format ### Motivation and Context Recently the modern models get larger and larger. Models with external data become common. The ONNX textual format is good for human writing and reading. But is dose not implement the external data format, yet. This PR implement it. --------- Signed-off-by: yoco <yoco@skymizer.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: yoco <yoco@skymizer.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the implementation of ONNX textual printer / parser to handle external data format
Motivation and Context
Recently the modern models get larger and larger. Models with external data become common.
The ONNX textual format is good for human writing and reading. But is dose not implement the
external data format, yet. This PR implement it.