Skip to content

Commit

Permalink
[github] use Node 18 for all workflows (expo#25307)
Browse files Browse the repository at this point in the history
# Why

React-native 0.73.0 requires the node version to be >=18

e.g.
https://github.com/expo/expo/actions/runs/6819379798/job/18546623746?pr=24971

# How

Ensure that we are using Node 18 in all of the workflows.

# Test Plan

Run the CI

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
  • Loading branch information
gabrieldonadel committed Nov 10, 2023
1 parent dfc72c5 commit 8c3553e
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android-instrumentation-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: 👀 Check out repository
uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: 👀 Check out repository
uses: actions/checkout@v3
with:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/docs-pr-deploy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: docs-pr-deploy

defaults:
Expand Down Expand Up @@ -37,7 +36,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/home.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/native-component-list.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-suite-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: 🔨 Use JDK 11
uses: actions/setup-java@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: ⬢ Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: ♻️ Restore caches
uses: ./.github/actions/expo-caches
id: expo-caches
Expand Down

0 comments on commit 8c3553e

Please sign in to comment.