Add support for scraping tags in radarr #174
Merged
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtrox
requested changes
May 28, 2023
internal/arr/collector/radarr.go
Outdated
| @@ -72,6 +73,12 @@ func NewRadarrCollector(c *config.ArrConfig) *radarrCollector { | |||
| []string{"quality"}, | |||
| prometheus.Labels{"url": c.URL}, | |||
| ), | |||
| movieTags: prometheus.NewDesc( | |||
There was a problem hiding this comment.
Can we match the naming convention of the other metrics?
Something like movieTagsMetric?
internal/arr/model/radarr.go
Outdated
| @@ -16,3 +16,9 @@ type Movie []struct { | |||
| } `json:"movieFile"` | |||
| QualityProfileID int `json:"qualityProfileId"` | |||
| } | |||
|
|
|||
| type TagObjects []struct { | |||
There was a problem hiding this comment.
This is specific to radarr, let's call this TagMovies
internal/arr/collector/radarr.go
Outdated
| @@ -72,6 +73,12 @@ func NewRadarrCollector(c *config.ArrConfig) *radarrCollector { | |||
| []string{"quality"}, | |||
| prometheus.Labels{"url": c.URL}, | |||
| ), | |||
| movieTags: prometheus.NewDesc( | |||
| "radarr_movie_tag_total", | |||
| "Tags by total", | |||
There was a problem hiding this comment.
Same here, can we match the other metrics?
"Total number of downloaded movies by tag"
onedr0p
reviewed
May 28, 2023
onedr0p
requested changes
May 28, 2023
rtrox
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new metric, the number of movies in a tag
No known limitations
Proof of functionality:
Description of the change
Add a new metric which scrapes radarr tags and the movies inside them
Benefits
Additional metrics are always nice?
Possible drawbacks
Any drawbacks that come from adding a new metric.