Add Panic Recovery & Logging to Client JSON Unmarshalling #139
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Russell Troxel <russell.troxel@segment.com>
Signed-off-by: Russell Troxel <russell.troxel@segment.com>
onedr0p
approved these changes
Mar 28, 2023
|
Nice work @rtrox ! |
rtrox
added a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds an unmarshalBody function, which, when the JSON serializer panics, will recover the panic, and return it as an error instead.
If
--log-level debugis set, the body of the response will be added to the log message as a string, to allow debugging of the json Decoder.Benefits
Stability & Debuggability -- JSON failures will not trigger crashes, and when such a failure occurs,
--log-level debugwill be able to retrieve information to simplify the fix. According tozap's documentation, we should already get a stack trace with error messages of error or higher.Possible drawbacks
N/A
Applicable issues