revert mapper changes #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simulators/ethereum/engine: Withdrawals Sanity test * simulators/ethereum/engine: CLMock changes * simulators/ethereum/engine: Add timestamp global * simulators/ethereum/engine: Withdrawals required changes * simulators/ethereum/engine: Fix request payload * simulators/ethereum/engine: Withdrawals tests * simulators/ethereum/engine: Withdrawals tests update * simulators/ethereum/engine: Test spec interface * simulators/ethereum/engine: Add withdrawals test cases * simulators/ethereum/engine: Withdraw many accounts fix * simulators/ethereum/engine: Withdrawals sync tests * simulators/ethereum/engine: Withdrawals re-org * simulators/ethereum/engine: More withdrawals tests * simulators/ethereum/engine: Variable timestamp increments on CLMock * simulators/ethereum/engine: Withdrawals reorg changes * simulators/ethereum/engine: withdrawals reorg tests * simulators/ethereum/engine: Add LVH check * simulators/ethereum/engine: Dynamic genesis * simulators/ethereum/engine: Fix HTTP Transport usage * simulators/ethereum/engine: Roundtrip change * simulator/ethereum/engine: Add txs to withdrawal tests * simulators/ethereum/engine: Decrease withdrawals count * simulators/ethereum/engine: Withdrawals test change * simulators/ethereum/engine: Withdrawals, comments * simulators/ethereum/engine: fix lvh in withdrawals * simulators/ethereum/engine: go mod tidy * simulators/ethereum/engine: Fix lvh check on genesis * simulators/ethereum/engine: Fix long sync test * simulators/ethereum/engine: Fix sync tests take 2 * simulators/ethereum/engine: Add blockValue to getPayload * simulators/ethereum/engine: withdrawals, wei to gwei * simulators/ethereum/engine: fix genesis block * simulators/ethereum/engine: implement error code expect check * simulators/ethereum/engine: withdrawals, expect errors on invalid version * simulators/ethereum/engine: Withdrawals readme * simulators/ethereum/engine: update withdrawals readme * simulators/ethereum/engine: update test parameter, description * simulators/ethereum/engine: update branch * simulators/ethereum/engine: Support querying txs from client * simulators/ethereum/engine: Add eip 3860 invalid tx test * simulators/ethereum/engine: fix gaslimit everywhere Co-authored-by: marioevz <marioevz@gmail.com>
…ys (ethereum#674) * Add bootnode check to avoid duplicated enode address * Add shanghaiTime to mapper.jq Co-authored-by: gfukushima <gabriel.fukushima@gmail.com>
…um#681) This adds a simulator and tests for the Capella beacon chain fork (including withdrawals). There are no client changes here. Some CL client definitions will not pass these tests in their default branch and will require an explicit capella branch specification. As part of factoring out the eth2 testnet setup code into a standalone library, this change introduces a 'Go workspace' containing all eth2 simulator sub-modules. When hive builds the simulator, it will now use ./simulators/eth2 as the base directory and will locate the ./simulators/eth2/common module via the go.work file. When building the simulators outside of docker, the go tool locates the go.work file as well. Co-authored-by: marioevz <marioevz@gmail.com>
…pected (ethereum#685) This adds precise checking of EL balances after withdrawals have been processed.
There was an issue in the withdrawals calculations so that, when the chain missed a slot, it aborted with error, but it's normal to miss a block in a slot. Now the computing method allows to skip a slot, and the calculations are still correct, the test passes for client combinations that might occasionally miss a slot.
…al amounts, more fixes (ethereum#694)
A big update for cmd/hiveview. - All external resources are now bundled in hiveview, so the app can run without Internet access. - External CSS/JS libraries have been updated to the latest version. - The index page and suite page are now separate documents. This makes browser navigation work better and is also a bit cleaner in the JS implementation. - When loading suite data and large log files, a progress bar is shown. - The 'expand' button in the test list was a bit confusing because it had a green icon when closed, and a red icon when opened. Since this was the only colored element on the page, it could be mistaken for test status. In the new version, the list of tests now shows red arrows for failed tests and gray ones for passed tests. - It is now possible to link to a test. When clicking on a test in the list, the test becomes 'selected', which is indicated by a yellow background. The selected test is stored in the page URL. - Output from tests is now limited to 50 lines to avoid freezing the browser. If there is more output, a link to the log viewer is shown. The log viewer can now display the output of a single test. - In the log viewer, a link back to the test is shown. This is useful when sharing a client log file with someone else, since they can go and check out the test case that generated the log. - Test output lines starting with `FAIL:`, `ERROR:` or `Error:` are shown in bold text. - The suite page now shows the duration of each test, as well as the overall suite duration and start time. - The new page header shows the hive commit and build date. This information is taken from `hive.json` in the workspace, so it will update whenever hive runs. - When a simulation run times out, hive now stores a `timeout` flag in the test results. The viewer app shows timeouts as a special kind of failure. - All timestamps are once again shown as local time. They were changed to UTC in commit beebe58, but I've since figured out how to sort by the ISO string and only convert to local time for display.
This enables the 'responsive' option for DataTable. With these changes, the viewer app is somewhat usable on small screens without horizontal scrolling.
…ghai (ethereum#699) INVALID_BLOCK_HASH is deprecated in Shanghai
…bilities (ethereum#698) Adds tests for engine_getPayloadBodiesByRangeV1, engine_getPayloadBodiesByHashV1 and engine_exchangeCapabilities.
This fixes a few small issues I noticed after deploying the new UI to hivetests.ethdevops.io. * cmd/hiveview: improve error highlight * cmd/hiveview: fix trim of /results/ in log title * cmd/hiveview: improve line highlight in viewer * cmd/hiveview: improve column widths on index page * cmd/hiveview: add scroll-margin for suite table highlight
* cmd/hiveview: fix some more CSS issues in viewer * cmd/hiveview: fix crash in viewer JS for big files * cmd/hiveview: fix margin * cmd/hiveview: fix row highlight * cmd/hiveview: prevent wrap of status * cmd/hiveview: enlarge suite name column * cmd/hiveview: prevent JSON-RPC error message highlight * cmd/hiveview: render hidden columns in test details
Increase tests coverage to match expectations of checklist here: https://hackmd.io/@n0ble/rywPcPTci
Another round of fixes for minor issues in the hiveview UI. * cmd/hiveview: fix typo in loader * cmd/hiveview: add spinner on index page * cmd/hiveview: include test id in client log link This makes it possible to go back to the test that created the client log. * cmd/hiveview: show test number in link back to suite * cmd/hiveview: improve line highlight * cmd/hiveview: fix scroll-margin in tests table
* wip * wip * wip * feat: add initial block import part of script (ethereum#1) * set up init and import commands * reorder reth commands * change command style * feat: load rest of test chain * feat: enable rpc * fix: correct genesis hex mapper * use apt instead of apk --------- Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me> Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Rjected
force-pushed
the
dan/remove-mapper-fields
branch
from
0d2d08b
to
ce6efbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were passing the
gasLimitfield intoinfix_zeros_to_lengthThis resulted in the gas limit having one less zero byte for devp2p tests:
When it should have been:
Instead of fixing the methods, this just removes the additional mappings, because the tests should work without them due to fixes in gakonst/ethers-rs#2145